Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add application emojis #678

Merged
merged 13 commits into from
Sep 21, 2024
Merged

Add application emojis #678

merged 13 commits into from
Sep 21, 2024

Conversation

Rapougnac
Copy link
Member

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Use smart commits here to manipulate issues (eg. Fixes #issue)

Connected issues & other potential problems

If changes in PR are connected to other issues or are affecting code in other parts of framework
(e.g. in main package or any other subpackage) make sure to link issue/PR and describe said problem

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Ran dart analyze or make analyze and fixed all issues
  • Ran dart format --set-exit-if-changed -l 160 ./lib or make format and fixed all issues
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Rapougnac Rapougnac marked this pull request as ready for review September 7, 2024 14:12
lib/src/manager_mixin.dart Outdated Show resolved Hide resolved
lib/src/http/managers/emoji_manager.dart Outdated Show resolved Hide resolved
@Rapougnac Rapougnac self-assigned this Sep 7, 2024
@Rapougnac Rapougnac added the enhancement New feature or request label Sep 7, 2024
@kingmigdor
Copy link
Contributor

I am getting the following error while testing:

Error: type '_Map<String, dynamic>' is not a subtype of type 'List<dynamic>' in type cast
Stack trace: #0      ApplicationManager.listApplicationEmojis (package:nyxx/src/http/managers/application_manager.dart:220:25)

This is due to the returned body not actually being a List. It's Map<String, dynamic> with the "items" key being a List. I tried printing out an empty result on this:

{items: []}

Not sure what's the direct cause of this is though.

@l7ssha l7ssha added this to the 6.4.0 milestone Sep 13, 2024
@Rapougnac Rapougnac merged commit 56ec264 into dev Sep 21, 2024
7 checks passed
@Rapougnac Rapougnac deleted the feat/app-emojis branch September 21, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Ready for deploy
Development

Successfully merging this pull request may close these issues.

4 participants